Adding and removing IBFT validators

Prerequisites

IBFT network as configured in IBFT tutorial.

Adding additional validator

Create a working directory for the new node that needs to be added
```
mkdir node5
```

Change into the working directory for the new node 5 and run istanbul setup:

cd node5
../istanbul-tools/build/bin/istanbul setup --num 1 --verbose --quorum --save

This will generate the validator details including Address, NodeInfo and genesis.json:

validators
{
    "Address": "0x2aabbc1bb9bacef60a09764d1a1f4f04a47885c1",
    "Nodekey": "25b47a49ef08f888c04f30417363e6c6bc33e739147b2f8b5377b3168f9f7435",
    "NodeInfo": "enode://273eaf48591ce0e77c800b3e6465811d6d2f924c4dcaae016c2c7375256d17876c3e05f91839b741fe12350da0b5a741da4e30f39553fe8790f88503c64f6ef9@0.0.0.0:30303?discport=0"
}

genesis.json
{
    "config": {
        "chainId": 10,
        "eip150Block": 1,
        "eip150Hash": "0x0000000000000000000000000000000000000000000000000000000000000000",
        "eip155Block": 1,
        "eip158Block": 1,
        "byzantiumBlock": 1,
        "istanbul": {
            "epoch": 30000,
            "policy": 0
        },
        "isQuorum": true
    },
    "nonce": "0x0",
    "timestamp": "0x5cffc942",
    "extraData": "0x0000000000000000000000000000000000000000000000000000000000000000f85ad5942aabbc1bb9bacef60a09764d1a1f4f04a47885c1b8410000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000c0",
    "gasLimit": "0xe0000000",
    "difficulty": "0x1",
    "mixHash": "0x63746963616c2062797a616e74696e65206661756c7420746f6c6572616e6365",
    "coinbase": "0x0000000000000000000000000000000000000000",
    "alloc": {
        "2aabbc1bb9bacef60a09764d1a1f4f04a47885c1": {
            "balance": "0x446c3b15f9926687d2c40534fdb564000000000000"
        }
    },
    "number": "0x0",
    "gasUsed": "0x0",
    "parentHash": "0x0000000000000000000000000000000000000000000000000000000000000000"
}

Copy the address of the validator and propose it from more than half the number of current validators.

Attach geth console to the node:

cd ..
geth attach node0/data/geth.ipc

Result:

Welcome to the Geth JavaScript console!

instance: Geth/v1.8.18-stable-bb88608c(quorum-v2.2.3)/darwin-amd64/go1.10.2
coinbase: 0x4c1ccd426833b9782729a212c857f2f03b7b4c0d
at block: 137 (Tue, 11 Jun 2019 16:32:47 BST)
 datadir: /Users/username/fromscratchistanbul/node0/data
 modules: admin:1.0 debug:1.0 eth:1.0 istanbul:1.0 miner:1.0 net:1.0 personal:1.0 rpc:1.0 txpool:1.0 web3:1.0

Check existing validators:

istanbul.getValidators()

Result:

["0x189d23d201b03ae1cf9113672df29a5d672aefa3", "0x44b07d2c28b8ed8f02b45bd84ac7d9051b3349e6", "0x4c1ccd426833b9782729a212c857f2f03b7b4c0d", "0x7ae555d0f6faad7930434abdaac2274fd86ab516", "0xc1056df7c02b6f1a353052eaf0533cc7cb743b52"]

Propose new validator using the command istanbul.propose(<address>, true) with <address> replaced by the new validator candidate node address:

istanbul.propose("0x2aabbc1bb9bacef60a09764d1a1f4f04a47885c1",true)

Result:

null

Exit console:

exit

Repeat the proposal process for this candidate node by connecting your geth console to node 1, node2 and node 3.

Verify that the new validator is now in the list of validators by running istanbul.getValidators() in a geth console attached to any of your nodes.

istanbul.getValidators()

Result:

["0x189d23d201b03ae1cf9113672df29a5d672aefa3", "0x2aabbc1bb9bacef60a09764d1a1f4f04a47885c1", "0x44b07d2c28b8ed8f02b45bd84ac7d9051b3349e6", "0x4c1ccd426833b9782729a212c857f2f03b7b4c0d", "0x7ae555d0f6faad7930434abdaac2274fd86ab516", "0xc1056df7c02b6f1a353052eaf0533cc7cb743b52"]

The list of validators contains 6 addresses now.

Copy static-nodes.json and genesis.json from the existing chain. static-nodes.json should be placed into new nodes data dir:
```
cd node5
mkdir -p data/geth
cp ../node0/static-nodes.json data
cp ../node0/genesis.json .
```

Edit static-nodes.json and add the new validators node info to the end of the file. New validators node info can be retrieved from the output of istanbul setup --num 1 --verbose --quorum --save command that was run in step 2. Update the IP address and port of the node info to match the IP address of the validator and port you want to use.

Edit data/static-nodes.json and add new validate nodes details with correct IP and port details:

[
    "enode://dd333ec28f0a8910c92eb4d336461eea1c20803eed9cf2c056557f986e720f8e693605bba2f4e8f289b1162e5ac7c80c914c7178130711e393ca76abc1d92f57@127.0.0.1:30300?discport=0",
    "enode://1bb6be462f27e56f901c3fcb2d53a9273565f48e5d354c08f0c044405b29291b405b9f5aa027f3a75f9b058cb43e2f54719f15316979a0e5a2b760fff4631998@127.0.0.1:30301?discport=0",
    "enode://0df02e94a3befc0683780d898119d3b675e5942c1a2f9ad47d35b4e6ccaf395cd71ec089fcf1d616748bf9871f91e5e3d29c1cf6f8f81de1b279082a104f619d@127.0.0.1:30302?discport=0",
    "enode://3fe0ff0dd2730eaac7b6b379bdb51215b5831f4f48fa54a24a0298ad5ba8c2a332442948d53f4cd4fd28f373089a35e806ef722eb045659910f96a1278120516@127.0.0.1:30303?discport=0",
    "enode://e53e92e5a51ac2685b0406d0d3c62288b53831c3b0f492b9dc4bc40334783702cfa74c49b836efa2761edde33a3282704273b2453537b855e7a4aeadcccdb43e@127.0.0.1:30304?discport=0",
    "enode://273eaf48591ce0e77c800b3e6465811d6d2f924c4dcaae016c2c7375256d17876c3e05f91839b741fe12350da0b5a741da4e30f39553fe8790f88503c64f6ef9@127.0.0.1:30305?discport=0"
]

Copy the nodekey that was generated by istanbul setup command to the geth directory inside the working directory
```
cp 0/nodekey data/geth
```

Generate one or more accounts for this node and take down the account address.

geth --datadir data account new

Result:

INFO [06-12|17:45:11.116] Maximum peer count                       ETH=25 LES=0 total=25
Your new account is locked with a password. Please give a password. Do not forget this password.
Passphrase:

Input your passphrase and repeat it:

Repeat passphrase:

Result:

Address: {37922bce824bca2f3206ea53dd50d173b368b572}

Initialize new node with the following command:

geth --datadir data init genesis.json

Result:

INFO [06-11|16:42:27.120] Maximum peer count                       ETH=25 LES=0 total=25
INFO [06-11|16:42:27.130] Allocated cache and file handles         database=/Users/username/fromscratchistanbul/node5/data/geth/chaindata cache=16 handles=16
INFO [06-11|16:42:27.138] Writing custom genesis block
INFO [06-11|16:42:27.138] Persisted trie from memory database      nodes=6 size=1.01kB time=163.024µs gcnodes=0 gcsize=0.00B gctime=0s livenodes=1 livesize=0.00B
INFO [06-11|16:42:27.139] Successfully wrote genesis state         database=chaindata                                                  hash=b992be…533db7
INFO [06-11|16:42:27.139] Allocated cache and file handles         database=/Users/username/fromscratchistanbul/node5/data/geth/lightchaindata cache=16 handles=16
INFO [06-11|16:42:27.141] Writing custom genesis block
INFO [06-11|16:42:27.142] Persisted trie from memory database      nodes=6 size=1.01kB time=94.57µs   gcnodes=0 gcsize=0.00B gctime=0s livenodes=1 livesize=0.00B
INFO [06-11|16:42:27.142] Successfully wrote genesis state         database=lightchaindata                                                  hash=b992be…533db7

Copy startall.sh to a new start5.sh and execute it to start the node:

cd ..
cp startall.sh start5.sh

Edit start5.sh with the following:

#!/bin/bash
cd node5
PRIVATE_CONFIG=ignore nohup geth --datadir data --nodiscover --istanbul.blockperiod 5 --syncmode full --mine --minerthreads 1 --verbosity 5 --networkid 10 --rpc --rpcaddr 0.0.0.0 --rpcport 22005 --rpcapi admin,db,eth,debug,miner,net,shh,txpool,personal,web3,quorum,istanbul --emitcheckpoints --port 30305 2>>node.log &

Important

Update IP and port number matching for this node decided on step 6

Run node 5:

./start5.sh

Check that the node is started:

ps

Result:

  PID TTY           TIME CMD
10554 ttys000    0:00.11 -bash
21829 ttys001    0:00.03 -bash
 9125 ttys002    0:00.93 -bash
36432 ttys002    0:24.48 geth --datadir data --nodiscover --istanbul.blockperiod 5 --syncmode full --mine --minerthreads 1 --verbosity 5 --networkid 10 --rpc --rpcaddr 0.0.0.0 --rpcport 22000 --rpcapi admin,
36433 ttys002    0:23.36 geth --datadir data --nodiscover --istanbul.blockperiod 5 --syncmode full --mine --minerthreads 1 --verbosity 5 --networkid 10 --rpc --rpcaddr 0.0.0.0 --rpcport 22001 --rpcapi admin,
36434 ttys002    0:24.32 geth --datadir data --nodiscover --istanbul.blockperiod 5 --syncmode full --mine --minerthreads 1 --verbosity 5 --networkid 10 --rpc --rpcaddr 0.0.0.0 --rpcport 22002 --rpcapi admin,
36435 ttys002    0:24.21 geth --datadir data --nodiscover --istanbul.blockperiod 5 --syncmode full --mine --minerthreads 1 --verbosity 5 --networkid 10 --rpc --rpcaddr 0.0.0.0 --rpcport 22003 --rpcapi admin,
36436 ttys002    0:24.17 geth --datadir data --nodiscover --istanbul.blockperiod 5 --syncmode full --mine --minerthreads 1 --verbosity 5 --networkid 10 --rpc --rpcaddr 0.0.0.0 --rpcport 22004 --rpcapi admin,
36485 ttys002    0:00.15 geth --datadir data --nodiscover --istanbul.blockperiod 5 --syncmode full --mine --minerthreads 1 --verbosity 5 --networkid 10 --rpc --rpcaddr 0.0.0.0 --rpcport 22005 --rpcapi admin,
36455 ttys003    0:00.04 -bash
36467 ttys003    0:00.32 geth attach node3/data/geth.ipc

Removing validators

Attach Geth console to a running validator and run istanbul.getValidators() and identify the address of the validator that needs to be removed:

geth attach node0/data/geth.ipc

Result:

Welcome to the Geth JavaScript console!

instance: Geth/v1.8.18-stable-bb88608c(quorum-v2.2.3)/darwin-amd64/go1.10.2
coinbase: 0xc1056df7c02b6f1a353052eaf0533cc7cb743b52
at block: 181 (Tue, 11 Jun 2019 16:36:27 BST)
 datadir: /Users/username/fromscratchistanbul/node0/data
 modules: admin:1.0 debug:1.0 eth:1.0 istanbul:1.0 miner:1.0 net:1.0 personal:1.0 rpc:1.0 txpool:1.0 web3:1.0

Run command:

istanbul.getValidators()

Result:

["0x189d23d201b03ae1cf9113672df29a5d672aefa3", "0x2aabbc1bb9bacef60a09764d1a1f4f04a47885c1", "0x44b07d2c28b8ed8f02b45bd84ac7d9051b3349e6", "0x4c1ccd426833b9782729a212c857f2f03b7b4c0d", "0x7ae555d0f6faad7930434abdaac2274fd86ab516", "0xc1056df7c02b6f1a353052eaf0533cc7cb743b52"]

We will remove 0x2aabbc1bb9bacef60a09764d1a1f4f04a47885c1 from the validator in this tutorial.

Run istanbul.propose(<address>, false) by passing the address of the validator that needs to be removed from more than half current validators:
```
istanbul.propose("0x2aabbc1bb9bacef60a09764d1a1f4f04a47885c1",false)
```
Result:
```
null
```
Repeat the istanbul.propose("0x2aabbc1bb9bacef60a09764d1a1f4f04a47885c1",false) for node 1, node 2 and node 3.

Verify that the validator has been removed by running istanbul.getValidators()

In one for the node’s attached geth console, run:

istanbul.getValidators()

Result:

["0x189d23d201b03ae1cf9113672df29a5d672aefa3", "0x44b07d2c28b8ed8f02b45bd84ac7d9051b3349e6", "0x4c1ccd426833b9782729a212c857f2f03b7b4c0d", "0x7ae555d0f6faad7930434abdaac2274fd86ab516", "0xc1056df7c02b6f1a353052eaf0533cc7cb743b52"]

The validators list now only have 5 addresses and the validator 0x2aabbc1bb9bacef60a09764d1a1f4f04a47885c1 was removed.

Stop the geth process corresponding to the validator that was removed.

ps

Result:

  PID TTY           TIME CMD
10554 ttys000    0:00.11 -bash
21829 ttys001    0:00.03 -bash
 9125 ttys002    0:00.94 -bash
36432 ttys002    0:31.93 geth --datadir data --nodiscover --istanbul.blockperiod 5 --syncmode full --mine --minerthreads 1 --verbosity 5 --networkid 10 --rpc --rpcaddr 0.0.0.0 --rpcport 22000 --rpcapi admin,
36433 ttys002    0:30.75 geth --datadir data --nodiscover --istanbul.blockperiod 5 --syncmode full --mine --minerthreads 1 --verbosity 5 --networkid 10 --rpc --rpcaddr 0.0.0.0 --rpcport 22001 --rpcapi admin,
36434 ttys002    0:31.72 geth --datadir data --nodiscover --istanbul.blockperiod 5 --syncmode full --mine --minerthreads 1 --verbosity 5 --networkid 10 --rpc --rpcaddr 0.0.0.0 --rpcport 22002 --rpcapi admin,
36435 ttys002    0:31.65 geth --datadir data --nodiscover --istanbul.blockperiod 5 --syncmode full --mine --minerthreads 1 --verbosity 5 --networkid 10 --rpc --rpcaddr 0.0.0.0 --rpcport 22003 --rpcapi admin,
36436 ttys002    0:31.63 geth --datadir data --nodiscover --istanbul.blockperiod 5 --syncmode full --mine --minerthreads 1 --verbosity 5 --networkid 10 --rpc --rpcaddr 0.0.0.0 --rpcport 22004 --rpcapi admin,
36485 ttys002    0:06.86 geth --datadir data --nodiscover --istanbul.blockperiod 5 --syncmode full --mine --minerthreads 1 --verbosity 5 --networkid 10 --rpc --rpcaddr 0.0.0.0 --rpcport 22005 --rpcapi admin,
36455 ttys003    0:00.05 -bash
36493 ttys003    0:00.22 geth attach node4/data/geth.ipc

Kill the geth process that uses port 22005, corresponding to node 5 as indicated in start5.sh:

kill 36485

Adding non-validator node

Same instructions as adding validator node excluding step 3 which proposes the node as validator.

Removing non-validator node

Just execute step 4 instruction from removing a validator node.